Skip to content

v2.1.x: Add volatile to the pointer in the list_item structure#3494

Merged
jsquyres merged 1 commit intoopen-mpi:v2.xfrom
jsquyres:pr/v2.1.x/opal-list-item-volatile
May 9, 2017
Merged

v2.1.x: Add volatile to the pointer in the list_item structure#3494
jsquyres merged 1 commit intoopen-mpi:v2.xfrom
jsquyres:pr/v2.1.x/opal-list-item-volatile

Conversation

@jsquyres
Copy link
Member

@jsquyres jsquyres commented May 9, 2017

This change has the side effect of improving the performance of all atomic data structures (in addition to making the code correct under a certain interpretation of the volatile usage).

Original issue: #3450
Master PR: #3468
Fixes #3477 (v2.1.x tracking issue)

Has been approved by @hjelmn @bwbarrett @bosilca on master.

Signed-off-by: George Bosilca bosilca@icl.utk.edu
(cherry picked from commit d7ebcca)
Signed-off-by: Jeff Squyres jsquyres@cisco.com

This change has the side effect of improving the performance of all
atomic data structures (in addition to making the code crrect under a
certain interpretation of the volatile usage).
This commit fixes open-mpi#3450.

Signed-off-by: George Bosilca <bosilca@icl.utk.edu>(cherry picked from commit d7ebcca)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
@jsquyres jsquyres added this to the v2.1.1 milestone May 9, 2017
@jsquyres jsquyres requested a review from hppritcha May 9, 2017 15:20
@jsquyres jsquyres changed the title v2.x: Add volatile to the pointer in the list_item structure. (#3468) v2.1.x: Add volatile to the pointer in the list_item structure. (#3468) May 9, 2017
@jsquyres jsquyres changed the title v2.1.x: Add volatile to the pointer in the list_item structure. (#3468) v2.1.x: Add volatile to the pointer in the list_item structure May 9, 2017
@jsquyres jsquyres merged commit 4da9a3d into open-mpi:v2.x May 9, 2017
@jsquyres jsquyres deleted the pr/v2.1.x/opal-list-item-volatile branch May 9, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants